![]() So if you have sources under "src" and want "build" as a sibling directory, cd to "build" and run configure as "./src/configure". ![]() It's as simple as that "working directory when you run 'configure'" is the build directory. Same if you want to test build with multiple compilers. If you want to test build against both Qt5 and Qt6, you have to have separate configurations for them (can't have -with-qtver=qt5 and -with-qtver=qt6 simultaneously). Probably the most typical use is to have separate build directories for building each client, though those multiple clients can be configured to a single configuration. The main advantage is that you can have multiple build directories with different configurations. I am almost certain it would generate the files in the source directory but i may be wrong. How do i configure separate build directories and why do you recommend to do so? For a number of reasons I recommend using separate build directories. gitignore -> new ticketĪre you using separate build director(y/ies), or have you configured the source directory? Just wondering if those files really get added to the source directory, or are they added to the build directory which happens to be same as source directory in your case. I don't think we have any linter config around (at least recent one) -> you may want to create a new ticket about adding one, e.g., under scripts/, and to have general discussion about it. gitignore so that i can just go back to doing "git add. as i am in the topic of development tools what do you use? i am using neovim with clangd as a language server and i really want to add. Ok, i am not detail oriented enough to catch all these minor mistakes by myself, do you have a linter already configured which you can pass me the config or will i need to find one and configure it? theses types of mistakes can be caught and fixed by a linter. fc_snprintf(filename,sizeof(filename), "%s/leset",path) load_ruleset_actions(actionfile,&compat_info) The function stub added there seems like start of #45039Īdd empty line between variable declarations and actual code.ĭeclaration of load_ruleset_actions() has the second parameter (on its own line) badly intended The ruleset.c change is a bit different from what I would have done myself, but I can't tell any specific problem that your way would cause -> seem acceptable. However, if you want to develop something in multiple commits, you should think if it indicates that there should actually be multiple tickets too. Just there generally should be just one commit (/branch) to the freeciv repo from each ticket. ![]() #Freeciv rulesets Patch#Of course I have nothing against you having multiple commits in your local tree, before squashing them to a patch to submit. Just to be sure only one commit per ticket? personally i like to have multiple commits, to do only one commit, i think i will normally do my commits and them use a interactive rebase to squash them into one. #Freeciv rulesets code#the idea is that i will move the action related code to load_actions_ruleset with the same name, and have it accept a compat info, so that it could load action related info from the game file. About the coding style comment, are you mentioning it specifically because i did something wrong or only in general? i read the coding style file and it doesn't seem to have anything wrong, My lines are shorter than 77 characters, i am using 2 spaces indentation, i am separating the keywords with spaces, so if there is something i am forgetting please mention it.Ībout the changes in server/ruleset.c is it a problem or can i just leave it as is? i almost certainly will use the function i created and i added a description for it,Ībout the if, analyzing it you can see that it checks the version of the format, and then if it is lower than the RSFORMAT_3_2 it checks if we are in compatibility mode, if yes it calls the load_ruleset _actions with the gamefile, if not it errors, if the version is equal or higher than RSFORMAT_3_2 it opens the actionfile checks if it is open then if so it it calls load_ruleset_actions. Wow, i forgot to change the scription field. I'll try to add more steps to the #41572 metaticket tonight. Set the descriptions correctly (only civ2civ3 one is part of civ2civ3, and they are "actions" data, "buildings" data)įor the code parts, read the doc/CodingStyle, and follow it.įor the ruleset.c part, in this ticket you should just openload_ruleset_file() leset, and even that only if the other rulesets already indicate that this is a 3.2 ruleset (compat->version >= RSFORMAT_3_2) OR you're not loading in compat mode at all (treat any ruleset as it was a 3.2 one, and do the error checking based on that). Add the standard comment of the supplied ruleset files on top ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |